Account Refresh Bugfix #105
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong value. The method previously return true if every account did not have its' sync in progress. I removed the `not` from before the return statement so that now it returns true if all accounts have started their sync. I am relatively certain that this is what the code should do, please close this branch if not.
hammem
reviewed
May 11, 2024
There was a problem hiding this comment.
@MichalikSJ21 , this method is intended to return true once all accounts have completed a refresh, rather than all initiating a sync.
The method request_account_refresh() will return True if the refresh initiation was successful.
|
@hammem That makes sense, thank you for clarifying that. I'll close this branch, I think that my code does not accomplish that result. Thanks for clarifying that for me! |
|
No worries! Thanks for the second set of eyes on the code 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where method
is_accounts_refresh_completereturned the wrong value. The method previously return true if every account did not have its' sync in progress. I removed thenotfrom before the return statement so that now it returns true if all accounts have started their sync. I am relatively certain that this is what the code should do, please close this branch if not.